-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update postgresql deployment documentation #16
Conversation
documentation/latest/gsg/ocp.md
Outdated
@@ -50,9 +50,13 @@ git clone {{ page.parodos.git_repo }} -b {{ page.parodos.git_branch }} | |||
|
|||
### Installing Parodos | |||
|
|||
Before appling the manifests please make sure you have a strageclass configured |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/strageclass/storageclass or even replace with:
[storage class](https://kubernetes.io/docs/concepts/storage/storage-classes/)
documentation/latest/gsg/ocp.md
Outdated
Before appling the manifests please make sure you have a [storage class](https://kubernetes.io/docs/concepts/storage/storage-classes/) | ||
configured and set as default. It is needed to bind persistent volume | ||
claim used by postgresql. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can provide a some suggestion/yaml snippet about the easiest way to configure it to let parodos work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. What do you think about providing a link to https://docs.openshift.com/container-platform/4.13/post_installation_configuration/storage-configuration.html ?
This PR fixes spelling mistake in the command and add information about requirement of funcional storage class.
TBH, I do not think that we should include the need to postgres in a GSG, I would avoid all to not create any miss-configuration at the user level. |
What do you suggest for the users to use in their environments? Any persistence layer needs to be there. |
As GSG, I would use an internal database as it is for kind, for example. You want to get started, not to complicated with external factors. IMHO |
@eloycoto I understand your point about getting started guide but we would need to have no recommendation how should be run long term. Internal db is not a solution if you want to survive container crash/restart/eviction. |
@eloycoto @pkliczewski what's the verdict? can this be merged? :-) |
I think we have much bigger issues with our manifests than making sure to configure storage class. We need to start providing easy way to deploy known version of services. Document how to customize db and ldap settings and provide some getting started guide on how to deploy both. I am ok to close this PR. |
This PR fixes spelling mistake in the command and add information about requirement of funcional storage class.